• walden@wetshav.ing
    link
    fedilink
    English
    arrow-up
    3
    arrow-down
    8
    ·
    edit-2
    4 days ago

    This has already been debated on the internet and I’m not an expert so I’m giving up. I guess it boils down to what is a “copyright”, and if the source in this case (PyLova) has a copright notice that needs to be copied over. That’s beyond my expertise.

    Edit:

    Read this if you want to, but I'm not completely convinced that I'm right

    “5”. Conveying Modified Source Versions.

    You may convey a work based on the Program, or the modifications to produce it from the Program, in the form of source code under the terms of section 4, provided that you also meet all of these conditions:

    a) The work must carry prominent notices stating that you modified it, and giving a relevant date.
    b) The work must carry prominent notices stating that it is released under this License and any conditions added under section 7. This requirement modifies the requirement in section 4 to “keep intact all notices”.
    c) You must license the entire work, as a whole, under this License to anyone who comes into possession of a copy. This License will therefore apply, along with any applicable section 7 additional terms, to the whole of the work, and all its parts, regardless of how they are packaged. This License gives no permission to license the work in any other way, but it does not invalidate such permission if you have separately received it.
    d) If the work has interactive user interfaces, each must display Appropriate Legal Notices; however, if the Program has interactive interfaces that do not display Appropriate Legal Notices, your work need not make them do so.

    A compilation of a covered work with other separate and independent works, which are not by their nature extensions of the covered work, and which are not combined with it such as to form a larger program, in or on a volume of a storage or distribution medium, is called an “aggregate” if the compilation and its resulting copyright are not used to limit the access or legal rights of the compilation’s users beyond what the individual works permit. Inclusion of a covered work in an aggregate does not cause this License to apply to the other parts of the aggregate.

    Thanks. I’m trying to understand where you’re seeing the requirement to give attribution still.

    I read this section as "if you use code from an AGPL project (PyLova in this case), then you need to:

    a) have a dated commit on the project that is using it (PieFed)
    b) keep the license the same
    c) the entire project (PieFed) now falls under this license (it does)
    d) have legal notices about it being AGPL, unless the original source (PieFed, then PyLova, then PieFed again) don’t have them.

    Then there’s a paragraph about aggregate projects and how the AGPL license doesn’t automatically spread to all parts of those projects.

    So I’m still confused where it’s required to say “Mia was the author”. All it’s saying is “this is AGPL code – keep it AGPL and make the code available for others to see.”

    • frongt@lemmy.zip
      link
      fedilink
      arrow-up
      9
      arrow-down
      1
      ·
      edit-2
      4 days ago

      Oh, I didn’t realize you meant the attribution. Section 5 is about declaring changes. Attribution comes from including the original license, which should have a line like "Copyright (C) <year> <name of author>", per the AGPL text.

      It doesn’t look like PyLova changed this when forking, because the top of the license file attributes the project to the FSF, and the bottom of the file attributes it to rimu. So both projects screwed this part up, because piefed should contain a line like “portions of this software copyright 2026 rimu atkinson”, and after picking the changes from PyLova, piefed should have “portions of this software copyright 2026” whoever is the author of the portions used.