Say I have a system that I want to enable or disable, what do you think is best: to write two separate functions EnableSystem() and DisableSystem() OR have a singular function with the parameter to indicate the desired state, SystemState(bool state)?

I was wondering if there is a standard for this or a preference?

I would argue that having two separate functions is better since different things might happen under those functions but what if it is the situation where it really is just as simple as a 1 or a 0. Example if we have an LED we want to turn on an off it would just be passing the value of the parameter state.

Situation one:

void LEDEnable() {
     GPIOPinSet(LED_PIN, true);
}

void LEDDisable() {
     GPIOPinSet(LED_PIN, false);
}

Situation two:

void LEDState(bool state) {
     GPIOPinSet(LED_PIN, state);
}
  • TiredDinoByte@lemmy.today
    1·
    2 天前

    I disagree, that it is mostly preference. I agree that it has been implemented both ways, but once you get into the scalability question, it becomes clear that passing in an argument cuts down on the logical branching. If you have both an enable and a disable function as your pattern, then for components you need to reason about state for during runtime will need an if/else which can get out of hand quickly when you are driving multiple component states.