tux snipes-hesitation

  • What I hate about the review vs generation disparity is that there’s suddenly pressure on the reviewer (the one gatekeeping poor quality work) to work faster under a greater workload.

    If I don’t review it quickly, someone who doesnt give a shit will, and they’ll hit approve on slop and get a gold star for doing it fast. If you make a comment, the contributor suddenly spams 5 commits with loads of changes which need reviewing - all while that same contributor gets to work on (ruin) other shit while you’re stuck with their mess.

    In my last job, I could work through a problem with someone to get a good submission, with compromise of course. Since then, I work with someone who swears by AI depsite barely having a grasp of programming and I straight up want to reject half of his PRs. But can I? No, because I’m at the same level as him and get given less respect by management because I’m not churning out slop so I can be free to get invites to other meetings for technical commentary. It’s a pisstake.

    • invalidusernamelol [he/him]@hexbear.net
      link
      fedilink
      English
      arrow-up
      5
      ·
      3 days ago

      I’m very happy that I’m lead/solo dev at my company because I get to just say no. If I don’t want to maintain it it doesn’t get done since everything I do is internal tooling.

      Also means that our whole company runs on a Python codebase with a single dependency. It took me 3 years to finally get around to vendoring a fast graphing library in our codebase because I wanted everything to be ours. We’ve had 3 other devs come through and only one of them has actually been able to produce something that got merged in.

      Maybe I’m just an insane person, but when all of production relies on our code, I want to know exactly how it works and where everything is.