Yes, underwear will help keep you from getting poop on your bike shorts. No, underwear will not keep ass sweat and smells out of your bike shorts for more than a couple minutes. So it depends on use case. As long as you are dingle berry free, an extra layer of fabric isn’t going to help much for smells.