This question is for ‘hero’ in all forms: realistic, fiction, superhero, comic book, anime, etc. Let’s say a person is flawed, or is very arrogant, or has a superiority complex, etc., but also does heroic things—like being a firefighter, doctor, wizard, superhero, whatever. Do you think that person is still a hero despite having negative personality traits?
No. Who you described at the end is what is called an Anti-Hero, who is someone who can do good things but they do them their own way which might not always be the right or correct way to solve a problem. Even if the problem was solved.
Deadpool is an anti-hero - loves killing people and partaking in all sorts of immoral things, but is doing good deeds by only doing the killing on bad people.
An arrogant person like Tony Stark is not an anti-hero, just a hero.
Now in real life, well it’s a completely different story. I’d say it’s just more that anyone can do heroic acts no matter how bad of a person they are.